Conversation
… with excessive size value Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds strict validation of the Kinesis stream ShardCount parameter at the provider API boundary to prevent excessive or invalid slice allocations, returning a ValidationException for out-of-range values while preserving existing defaults and internals. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
skyoo2003
changed the title
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The hardcoded
1024in the error message could easily drift frommaxShardCount; consider formatting the message using themaxShardCountconstant instead of duplicating the literal.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The hardcoded `1024` in the error message could easily drift from `maxShardCount`; consider formatting the message using the `maxShardCount` constant instead of duplicating the literal.
## Individual Comments
### Comment 1
<location path="internal/services/kinesis/provider.go" line_range="203-204" />
<code_context>
return jsonErr("ValidationException", "StreamName is required", http.StatusBadRequest), nil
}
shardCount := intParam(params, "ShardCount", 1)
+ if shardCount <= 0 || shardCount > maxShardCount {
+ return jsonErr("ValidationException", "ShardCount must be between 1 and 1024", http.StatusBadRequest), nil
+ }
mode := "PROVISIONED"
</code_context>
<issue_to_address>
**suggestion:** Avoid hardcoding the upper bound in the error message to keep it consistent with `maxShardCount`.
The validation already relies on `maxShardCount`, but the message still hardcodes `1024`, which could become misleading if `maxShardCount` changes. Consider formatting the error string with `maxShardCount` so it always reflects the actual limit.
Suggested implementation:
```golang
if shardCount <= 0 || shardCount > maxShardCount {
return jsonErr("ValidationException", fmt.Sprintf("ShardCount must be between 1 and %d", maxShardCount), http.StatusBadRequest), nil
}
```
1. Ensure `fmt` is imported at the top of `internal/services/kinesis/provider.go`:
- If not already present, add `fmt` to the import block, e.g.:
`import ("fmt" /* existing imports... */)`.
2. If the file uses grouped imports, keep `fmt` alphabetically ordered with the existing imports to match project conventions.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/skyoo2003/devcloud/security/code-scanning/21
Add a strict maximum allowed shard count and enforce it in stream creation handling, while preserving existing behavior for valid inputs.
Best single fix:
internal/services/kinesis/provider.go, validateShardCountincreateStreamafter reading it withintParam.ShardCountis out of range, return aValidationException(HTTP 400) and do not call the store.default 1) and avoid changing storage internals/function signatures.Why here: validation belongs at the API boundary where user input is interpreted, and it prevents all downstream variants (including the sink in
store.go) with one guard.Suggested fixes powered by Copilot Autofix. Review carefully before merging.